Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: codecov_fix #8294

Merged
merged 1 commit into from
Apr 18, 2023
Merged

fix: codecov_fix #8294

merged 1 commit into from
Apr 18, 2023

Conversation

amina-deriv
Copy link
Contributor

Changes:

Please include a summary of the change and which issue is fixed below:

  • ...

When you need to add unit test

  • If this change disrupt current flow
  • If this change is adding new flow

When you need to add integration test

  • If components from external libraries are being used to define the flow, e.g. @deriv/components
  • If it relies on a very specific set of props with no default behavior for the current component.

Test coverage checklist (for reviewer)

  • Ensure utility / function has a test case
  • Ensure all the tests are passing

Type of change

  • Bug fix
  • New feature
  • Update feature
  • Refactor code
  • Translation to code
  • Translation to crowdin
  • Script configuration
  • Improve performance
  • Style only
  • Dependency update
  • Documentation update
  • Release

@vercel
Copy link

vercel bot commented Apr 18, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2023 11:31am

@sonarcloud
Copy link

sonarcloud bot commented Apr 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/binary-com/deriv-app/pull/8294](https://github.com/binary-com/deriv-app/pull/8294)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-amina-deriv-amina-codecovfix.binary.sx?qa_server=red.binaryws.com&app_id=32099
    - **Original**: https://deriv-app-git-fork-amina-deriv-amina-codecovfix.binary.sx
- **App ID**: `32099`

@github-actions
Copy link
Contributor

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 21
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-amina-deriv-amina-codecovfix.binary.sx/

@codecov-commenter
Copy link

Codecov Report

Merging #8294 (358e643) into master (a4c37bd) will increase coverage by 0.06%.
The diff coverage is 50.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master    #8294      +/-   ##
==========================================
+ Coverage   20.70%   20.76%   +0.06%     
==========================================
  Files        1538     1538              
  Lines       35977    35979       +2     
  Branches     7033     7035       +2     
==========================================
+ Hits         7449     7471      +22     
+ Misses      27782    27769      -13     
+ Partials      746      739       -7
Impacted Files Coverage Δ
...re/src/App/Components/Layout/Header/menu-links.jsx 0.00% <0.00%> (ø)
...pp/Containers/Layout/header/trading-hub-header.jsx 0.00% <ø> (ø)
...ners/RealAccountSignup/change-account-currency.jsx 0.00% <0.00%> (ø)
packages/stores/src/mockStore.ts 0.00% <ø> (ø)
...ts/account-platform-icon/account-platform-icon.tsx 100.00% <100.00%> (+33.33%) ⬆️
...er/account-transfer-form/account-transfer-form.tsx 77.77% <100.00%> (+10.71%) ⬆️
...kages/cashier/src/stores/account-transfer-store.ts 87.62% <100.00%> (+0.04%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@amina-deriv amina-deriv merged commit 77b2f95 into deriv-com:master Apr 18, 2023
@nada-deriv
Copy link
Contributor

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@farrah-deriv farrah-deriv Awaiting requested review from farrah-deriv farrah-deriv is a code owner

@vinu-deriv vinu-deriv Awaiting requested review from vinu-deriv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amina-deriv @codecov-commenter @nada-deriv